Files that changed from the base of the PR and between c1cb39d and 885cdff.

• pyproject.toml (3 hunks)
• scripts/core-testing.sh (10 hunks)

scripts/core-testing.sh (11)

4-8: LGTM: Color variables improve output readability

The addition of color variables (CNORM, CFAIL, CINFO, CWARN) is a good improvement. It will enhance the readability of the script's output by providing visual cues for different types of messages (normal, failure, info, warning).

---

22-22: LGTM: Improved visibility of working branch information

The use of the CINFO color variable in the echo statement enhances the visibility of the working branch information. This is consistent with the newly added color scheme and improves user experience.

---

40-40: LGTM: Added pylint packages to pip_packages

The addition of "pylint" and "pylint-per-file-ignores" to the pip_packages variable is in line with the PR objective of re-adding pylint. This change will enable pylint checks in the testing process, improving code quality.

---

43-43: LGTM: Improved readability of echo statements

The modifications to these echo statements, using the newly defined color variables (CINFO, CFAIL), enhance the readability of the script's output. This change provides clear visual distinction between informational messages and potential error messages.

Also applies to: 45-45, 47-47

---

92-134: LGTM: Enhanced output and error handling in git operations

The modifications in this section significantly improve the script's user-friendliness:

1. The use of color variables (CINFO, CWARN) in echo statements enhances the visibility of different message types.
2. The added error handling for git commands (e.g., stash, clean, checkout) with informative colored output helps users understand the script's progress and any potential issues.

These changes make the script more robust and easier to debug if issues arise during execution.

---

173-198: LGTM: Consistent use of color variables and 'uv' for pip operations

The modifications in this section maintain consistency with previous changes:

1. The use of color variables (CINFO) in echo statements continues to enhance readability.
2. The switch to 'uv' for pip operations is applied consistently.

These changes improve the script's overall coherence and potentially its performance. However, as mentioned in the previous comment, please ensure that 'uv' is properly installed and compatible with all required pip operations in your environment.

---

207-211: LGTM: Consistent use of color variables for echo statements

The modifications to these echo statements, using the CINFO color variable, maintain consistency with the overall improvements in output readability throughout the script. This change enhances the visibility of important information during the test commencement phase.

---

Line range hint 239-281: LGTM: Improved output readability and addition of pre-commit checks

The modifications in this final section further enhance the script:

1. Consistent use of color variables (CINFO) in echo statements maintains the improved readability throughout the script.
2. The addition of a new section for running pre-commit checks (lines 279-282) is a valuable improvement. Pre-commit hooks are an excellent practice for catching issues before they're committed, which can significantly improve code quality and reduce the need for follow-up fixes.

echo -e "${CINFO}Core PR pre-commit check ...${CNORM}"
echo ""
git add -A ; pre-commit

This addition aligns well with the overall goal of improving code quality and the linting process.

---

Line range hint 1-290: Overall LGTM: Significant improvements to testing and quality assurance process

This PR introduces several valuable enhancements to the core-testing.sh script:

1. Improved readability: The consistent use of color variables for echo statements throughout the script significantly enhances output readability and user experience.

2. Enhanced error handling: Added informative error messages for git operations provide better visibility into the script's execution process.

3. Upgraded pip operations: The switch to 'uv' for pip operations potentially improves performance, though this change should be verified in the target environment.

4. Expanded linting capabilities: The addition of ruff checks and the re-introduction of pylint align well with the PR objective of improving code quality assurance.

5. Pre-commit checks: The new section for running pre-commit hooks is an excellent addition for catching issues early in the development process.

These changes collectively contribute to a more robust, user-friendly, and effective testing and quality assurance process.

Considerations for follow-up:

• Verify the 'uv' installation and compatibility in the target environment.
• Consider allowing configuration of the pylint job count (-j flag) to accommodate different system capabilities.

---

224-236: LGTM with a suggestion: Verify pylint command options

The additions in this section significantly improve the script's linting capabilities:

1. The introduction of ruff checks for both the component and tests is a good practice for maintaining code quality.
2. The re-addition of pylint checks aligns with the PR objective.
3. The use of color variables (CINFO, CWARN, CFAIL) in echo statements maintains consistency with previous changes and improves readability.

However, there's one point that might need verification:

pylint -j 0 --ignore-missing-annotations=y homeassistant/components/plugwise/*py tests/components/plugwise/*py

The -j 0 flag tells pylint to use as many parallel processes as possible. While this can speed up linting, it might cause issues on systems with limited resources. Consider setting a specific number of jobs or allowing the user to configure this.

To verify the pylint command options, you can run:

#!/bin/bash
# Check pylint version and available options
pylint --version
pylint --help | grep -E "^\s*-j"

# Test pylint with different job settings
echo "Testing with -j 0"
time pylint -j 0 --ignore-missing-annotations=y homeassistant/components/plugwise/*py tests/components/plugwise/*py

echo "Testing with -j 4"
time pylint -j 4 --ignore-missing-annotations=y homeassistant/components/plugwise/*py tests/components/plugwise/*py

echo "Testing without -j flag"
time pylint --ignore-missing-annotations=y homeassistant/components/plugwise/*py tests/components/plugwise/*py

This script will help you compare the performance and behavior of pylint with different job settings.

---

147-162: LGTM with a suggestion: Verify 'uv' usage for pip operations

The use of color variables (CINFO, CWARN) in echo statements continues to improve the script's readability and user experience.

However, the switch from pip install to uv pip install is a significant change:

-grep -v "^#" "${coredir}/script/bootstrap" | grep "pip install" | sh
+grep -v "^#" "${coredir}/script/bootstrap" | grep "pip install" | sed 's/python3 -m pip install/uv pip install/g' | sh

While 'uv' can potentially improve performance for pip operations, please ensure that:

1. 'uv' is installed and available in the environment where this script runs.
2. All necessary 'uv' features are compatible with the script's requirements.
3. This change doesn't introduce any unexpected behavior in the installation process.

To verify the 'uv' installation and compatibility, you can run:

pyproject.toml (4)

32-365: Comprehensive pylint configuration added

The addition of an extensive pylint configuration is a significant improvement. Key points:

1. Python version is set to 3.12, ensuring compatibility with the latest features.
2. Custom Home Assistant plugins are loaded, tailoring the linting to the project's needs.
3. Disabled checks are well-documented, showing careful consideration of each rule.
4. The configuration covers various aspects like basic checks, message control, and typing.

This configuration will greatly enhance code quality and consistency across the project.

---

373-388: Appropriate coverage configuration added

The coverage configuration is well-structured and includes common exclusions:

1. Specifies the source directory as "plugwise-beta".
2. Excludes debug-only code, assertion errors, and type checking blocks from coverage reporting.

This configuration will provide more accurate and meaningful test coverage reports.

---

Line range hint 1-31: Well-structured project metadata

The project metadata is comprehensive and provides essential information:

1. Project name, version, and description are clearly defined.
2. Authors and maintainers are listed.
3. Dependencies are specified, including "homeassistant" and "plugwise".
4. The required Python version (>=3.12) aligns with the pylint configuration.

This metadata provides a clear overview of the project and its requirements.

---

Line range hint 1-579: Excellent linting configuration overhaul

This PR successfully re-adds pylint and introduces comprehensive linting configurations:

1. Project metadata is well-defined and up-to-date.
2. Pylint configuration is extensive and tailored to the project's needs.
3. Coverage configuration ensures accurate test coverage reporting.
4. Ruff configuration provides an additional layer of code quality checks.

These changes will significantly improve code quality, consistency, and maintainability across the project. The configurations are well-structured and thoughtfully commented, making future maintenance easier.

Great job on this substantial improvement to the project's development tooling!