Conversation
…ri, and it appears that recent versions may not need it
|
Thanks @rlreamy - it's interesting that this works now, but it clearly didn't in past versions of Safari (and some docs haven't caught up yet, like https://www.w3schools.com/jsref/prop_anchor_download.asp still says "Not Supported") Can we instead move the special handling after the |
|
It would be really nice to get this PR to the finish line for the upcoming |
|
It is possible, but I cannot promise anything. This change was done as part of a work project, and I have not yet had time to revisit. |
|
Thanks very much @rlreamy for the information. |
|
💃 Thanks for the PR. |
Fix for issue #1227.
It appears that for Safari Version 14.0.1 (16610.2.11.51.8) the special code in fileSaver.js for handling Safari browsers is actually breaking the download. The filename is always "Unknown" and it doesn't download the entire image (in our case a scatter plot gave us only the axes and labels, but none of the points). Strangely a second try at the download will give the user the full plot, but the filename is still "Uknown".
Removing the special handling worked when testing with npm start.