Merged
Conversation
alexcjohnson
approved these changes
Nov 19, 2020
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Nice! And thanks for catching these @COLLINETTEBastien 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing a bug and a warning mentioned in #5289.
Namely:
Bug:
-line 69736: Suspicious code. This code lacks side-effects. Is there a bug?
if(!locale) locale === 'en-US';-line 69736: Suspicious code. The result of the 'sheq' operator is not being used.
if(!locale) locale === 'en-US';Shouldn't it be
if(!locale) locale = 'en-US';instead?Warning:
-line 87184: unreachable code
for(i = 0; i < traces.length; i++) {Since this for loop contains a
break;that cannot be avoided, is it relevant to use a for loop to only do things with i==0 while i < traces.length?@plotly/plotly_js