This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Check in fix for ES behind Nginx #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
|
Tested with the sample credentials (without setting the port). 💃 |
Contributor
|
I'd do a squash and merge (so that the eslint fixes don't add noise to the repo's history). |
Check in fix for ES behind Nginx fix ES Lint Issues
Merge branch 'master' of https://github.com/plotly/falcon-sql-client into v-316-Fix-ES-NGINX
Merge branch 'v-316-Fix-ES-NGINX' of https://github.com/shannonlal/falcon-sql-client into v-316-Fix-ES-NGINX
Check in fix for ES behind Nginx fix ES Lint Issues fix ES Lint Issues
Merge branch 'v-316-Fix-ES-NGINX' of https://github.com/shannonlal/falcon-sql-client into v-316-Fix-ES-NGINX
Contributor
|
I've rebased this PR against current master in #377. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for #343 to handle the situation where Elastic Search is behind NGINX. This is a common situation on smaller Elastic Search DBs that do not want to use X-Pack to handle authentication. When the port is not defined it will exclude the port from the url and attempt to connect as is.