This repository was archived by the owner on Aug 29, 2025. It is now read-only.
issue #834 fix when pagination doesn't work when more than one table …#907
Merged
alexcjohnson merged 7 commits intoplotly:devfrom Jun 25, 2021
Merged
issue #834 fix when pagination doesn't work when more than one table …#907alexcjohnson merged 7 commits intoplotly:devfrom
alexcjohnson merged 7 commits intoplotly:devfrom
Conversation
…table is on the page
alexcjohnson
reviewed
Jun 3, 2021
alexcjohnson
reviewed
Jun 4, 2021
alexcjohnson
approved these changes
Jun 4, 2021
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
Fantastic! 💃
If you merge dev back in here the CI tests should run correctly again.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two pagination issues:
Where pagination buttons are not visible or do not work because another table or figure overlaps the pagination container.
If you are on a page that no longer exists after data is updated, then no data shows in the table. This is fixed by resetting the
page_currentto 0Pagination buttons now work in the example from 834:
Pagination buttons are are now visible here: https://dash.plotly.com/datatable/interactivity
