Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

fix empty dropdown regression#85

Merged
Marc-Andre-Rivet merged 4 commits intomasterfrom
3.0-issue83-dropdown-delete
Sep 12, 2018
Merged

fix empty dropdown regression#85
Marc-Andre-Rivet merged 4 commits intomasterfrom
3.0-issue83-dropdown-delete

Conversation

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

No description provided.

return typeof candidate === 'object' && candidate.constructor === Object;
return candidate !== undefined &&
candidate !== null &&
typeof candidate === 'object' &&
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeof null is 'object', this caused an error to be thrown, adding check for undefined just so it's all very explicit

});

DashTable.getCell(0, 8).within(() => cy.get('.Select-placeholder').should('not.exist'));
});
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test for delete + test for delete + set value after

Marc-André Rivet added 3 commits September 12, 2018 12:43
…n-delete

# Conflicts:
#	CHANGELOG.md
#	dash_table/bundle.js
#	dash_table/demo.js
#	dash_table/package.json
#	package.json
Copy link
Copy Markdown
Contributor

@wbrgss wbrgss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix #83, and safer type checks are a good idea, so 💃 from me.

Too bad using TypeScript is unable to prevent these sorts of type errors on runtime. The fact that typeof null === 'object' is true is pretty bad.

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 06ac08f into master Sep 12, 2018
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 3.0-issue83-dropdown-delete branch September 27, 2018 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants