This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Conversation
added 8 commits
August 11, 2020 16:21
|
|
||
| return config; | ||
| } | ||
| }; No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Storybook 6 brings totally new configuration files and opinions. Making it work with our own needs..
Contributor
There was a problem hiding this comment.
@Marc-Andre-Rivet For any package using Storybook >=6, I imagine we now have to add
config.resolve.alias['dash-table'] = path.resolve(__dirname, './../src/dash-table')but specific to the path/package name?
Contributor
Author
There was a problem hiding this comment.
Yes. But the table is the only project using storybook.
| cy.visit(`http://localhost:8080?mode=${AppMode.Markdown}`); | ||
| // wait for highlight.js to highlight code | ||
| DashTable.getCellById(0, 'markdown-code-blocks').within(() => cy.get('code.language-python span.hljs-title')); | ||
| DashTable.getCellById(0, 'markdown-code-blocks').within(() => cy.get('code.language-python')); |
Contributor
Author
There was a problem hiding this comment.
highlight.js 10 does not wrap the code in a span anymore, updating the test
rpkyle
approved these changes
Aug 13, 2020
|
|
||
| return config; | ||
| } | ||
| }; No newline at end of file |
Contributor
There was a problem hiding this comment.
@Marc-Andre-Rivet For any package using Storybook >=6, I imagine we now have to add
config.resolve.alias['dash-table'] = path.resolve(__dirname, './../src/dash-table')but specific to the path/package name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some maintenance work -- lest we fall behind and it becomes harder to maintain it up to date.