Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 703 - Rename async modules#704

Merged
Marc-Andre-Rivet merged 5 commits intodevfrom
703-async-tilde
Feb 27, 2020
Merged

Issue 703 - Rename async modules#704
Marc-Andre-Rivet merged 5 commits intodevfrom
703-async-tilde

Conversation

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

Closes #703

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-704 February 27, 2020 02:06 Inactive
pip install -e .
python setup.py sdist
cd dist
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the opportunity to install from tarball instead of the local folder -e .. This change helps identify issues when resource paths change and the MANIFEST.in file isn't synced.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that seems important... Is this an issue in any of our other repos? Perhaps a followup issue to check on this as well?

Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 7a40b0c into dev Feb 27, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 703-async-tilde branch February 27, 2020 17:33
@ManojSN
Copy link
Copy Markdown

ManojSN commented Feb 27, 2020

nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename async modules

4 participants