Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 206 - Filter copy/paste#623

Merged
Marc-Andre-Rivet merged 5 commits intodevfrom
206-filter-copy-paste
Oct 9, 2019
Merged

Issue 206 - Filter copy/paste#623
Marc-Andre-Rivet merged 5 commits intodevfrom
206-filter-copy-paste

Conversation

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Oct 9, 2019

Fixes #206

Allow copy/paste from/to filter columns inputs.

Note: Sadly there's no good way to test this through Cypress. The table cell copy could be done because of the way the data is copied and pasted, could be shimmed with some tweaking. There's no clear path here.

Clipboard.clear();
TableClipboardHelper.lastLocalCopy = [];
TableClipboardHelper.localCopyWithoutHeaders = [];
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deal with the special table copy/paste code -- reset the previsouly set copies -- will pick up the last copy event normally when doing a paste from filter columns.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-623 October 9, 2019 18:46 Inactive
TableClipboardHelper.clearClipboard();
}}
onPaste={(e: any) => {
e.stopPropagation();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prevent copy/paste from being handled by the global table handler

Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 95328a9 into dev Oct 9, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 206-filter-copy-paste branch October 9, 2019 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copying and pasting strings into the filter cell doesn't work?

3 participants