Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 569 - Support empty strings in filter query#570

Merged
Marc-Andre-Rivet merged 2 commits intomasterfrom
569-filter-empty-string
Sep 5, 2019
Merged

Issue 569 - Support empty strings in filter query#570
Marc-Andre-Rivet merged 2 commits intomasterfrom
569-filter-empty-string

Conversation

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Sep 5, 2019 •
edited
Loading

- support empty string
594db72 
- update tests
- update changelog
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-570 September 5, 2019 15:12 Inactive
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review September 5, 2019 15:41
alexcjohnson
alexcjohnson approved these changes Sep 5, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 🚀

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 4d0619f into master Sep 5, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 569-filter-empty-string branch September 5, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter does not support empty strings filter_query of style_**_conditional cannot find empty value

3 participants

@Marc-Andre-Rivet @alexcjohnson @chriddyp