This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 524 - Readonly dropdown column content#530
Merged
Marc-Andre-Rivet merged 10 commits intomasterfrom Aug 5, 2019
Merged
Conversation
- test both the editable and readonly versions of the dropdown
Marc-Andre-Rivet
commented
Aug 2, 2019
| DashTable.getCell(2, 6).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); | ||
| DashTable.getCell(3, 6).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); | ||
|
|
||
| DashTable.getCell(0, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); |
Contributor
Author
There was a problem hiding this comment.
also check the readonly column
Marc-Andre-Rivet
commented
Aug 2, 2019
| DashTable.getCell(0, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Wet')); | ||
| DashTable.getCell(1, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Snowy')); | ||
| DashTable.getCell(2, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Tropical Beaches')); | ||
| DashTable.getCell(3, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); |
Contributor
Author
There was a problem hiding this comment.
also check the readonly column
Marc-Andre-Rivet
commented
Aug 2, 2019
| DashTable.getCell(0, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Wet')); | ||
| DashTable.getCell(1, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Snowy')); | ||
| DashTable.getCell(2, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Tropical Beaches')); | ||
| DashTable.getCell(3, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); |
Contributor
Author
There was a problem hiding this comment.
also check the readonly column
Marc-Andre-Rivet
commented
Aug 2, 2019
| DashTable.getCell(0, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); | ||
| DashTable.getCell(1, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); | ||
| DashTable.getCell(2, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); | ||
| DashTable.getCell(3, 7).within(() => cy.get('.dash-cell-value').should('have.html', 'label: Humid')); |
Contributor
Author
There was a problem hiding this comment.
also check the readonly column
Marc-Andre-Rivet
commented
Aug 2, 2019
| ) | ||
| } | ||
| }} | ||
| />) |
Contributor
Author
There was a problem hiding this comment.
visual tests for readonly and editable dropdowns
Contributor
Author
There was a problem hiding this comment.
Used in conjonction with the updated standalone tests above
Marc-Andre-Rivet
commented
Aug 5, 2019
| 'bbb-readonly': { | ||
| clearable: true, | ||
| options: ['Humid', 'Wet', 'Snowy', 'Tropical Beaches'].map(i => ({ | ||
| label: `label: ${i}`, |
Contributor
Author
There was a problem hiding this comment.
Differentiate between the label and value to catch these differences in the tests.
Marc-Andre-Rivet
commented
Aug 5, 2019
|
|
||
| enum CellType { | ||
| Dropdown, | ||
| DropdownLabel, |
Contributor
Author
There was a problem hiding this comment.
To make it easier to distinguish between the general label case and the dropdown one. Processing is different.
Marc-Andre-Rivet
commented
Aug 5, 2019
|
|
||
| DashTable.getFilterById('bbb').within(() => cy.get('input').should('have.value', 'Tr')); | ||
| DashTable.getCellById(0, 'bbb-readonly').within(() => cy.get('.dash-cell-value').should('have.html', 'Tropical Beaches')); | ||
| DashTable.getCellById(0, 'bbb-readonly').within(() => cy.get('.dash-cell-value').should('have.html', 'label: Tropical Beaches')); |
Contributor
Author
There was a problem hiding this comment.
Update tests involving dropdowns so as to expect the label: prefix
alexcjohnson
approved these changes
Aug 5, 2019
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
Works for me - nicely done. 💃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524. Fixes regression introduced by #281.