Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Copy paste headers#523

Merged
Marc-Andre-Rivet merged 14 commits intomasterfrom
copy-paste-headers
Aug 2, 2019
Merged

Copy paste headers#523
Marc-Andre-Rivet merged 14 commits intomasterfrom
copy-paste-headers

Conversation

@alinastarkov
Copy link
Copy Markdown
Contributor

@alinastarkov alinastarkov commented Aug 1, 2019

Closes #318

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-523 August 1, 2019 14:58 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-523 August 1, 2019 14:59 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-523 August 1, 2019 15:05 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-523 August 1, 2019 15:11 Inactive
const selectedRows = R.uniq(R.pluck('row', selectedCells).sort((a, b) => a - b));
const selectedCols: any = R.uniq(R.pluck('column', selectedCells).sort((a, b) => a - b));

const transposedHeaders = createHeadings(R.pluck('name', columns), getHeaderRows(columns));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging in with the hidden columns PR #508, will need to pass both the columns and visibleColumns -- visibleColumns for processing the data / creating the copy/paste info and columns (containing the hidden ones) to determine the number of header rows correctly

Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about the incoming master / #508 merge.

Missing the toggle prop for this behavior as defined in the issue

This setting would be set by the Dash developer through a property like “include_headers_on_copy_and_paste=True”.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-523 August 1, 2019 19:34 Inactive
Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃, 👍for the extra cross-table test

Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- reblocking -- seeing some issues, want to make sure if these are regressions or were present before

Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 unrelated problem, issue opened in #526

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 3b7c4f8 into master Aug 2, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the copy-paste-headers branch August 2, 2019 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ability to include column headers when copying-and-pasting

3 participants