Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Ability to export data as csv / xlsx file#499

Merged
alinastarkov merged 70 commits intomasterfrom
ExportTable
Jul 22, 2019
Merged

Ability to export data as csv / xlsx file#499
alinastarkov merged 70 commits intomasterfrom
ExportTable

Conversation

@alinastarkov
Copy link
Copy Markdown
Contributor

Closes #313

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-499 July 22, 2019 14:29 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-499 July 22, 2019 14:50 Inactive
<script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react-dom.js'></script>

<!-- <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js'></script>
<script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react-dom.js'></script> -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the two commented versions of React at this point.

demo/index.html Outdated
<div id='root'></div>
<script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js'></script>
<script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react-dom.js'></script>
<!-- <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js'></script>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-499 July 22, 2019 14:54 Inactive
css: IStylesheetRule[];
data: Data;
editable: boolean;
export_format: 'csv' | 'xlsx';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing none

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-499 July 22, 2019 15:00 Inactive
return wb;
}

export function createWorksheet(heading: string[][], data: any[], columnID: string[], exportHeader: string ) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Data type in tables/props.ts - sheet_add_json expects any[] but both types should be compatible as Data is resolved as (IDatumObject | any)[]

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-499 July 22, 2019 18:15 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-499 July 22, 2019 18:30 Inactive
Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Well done. Get this one out the door! :)

@alinastarkov alinastarkov merged commit 26c65f8 into master Jul 22, 2019
@alinastarkov alinastarkov deleted the ExportTable branch July 22, 2019 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to export data as excel or csv

3 participants