This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 435 - Table selected cell #444
Merged
alinastarkov merged 22 commits intomasterfrom May 31, 2019
Merged
Conversation
|
|
||
| map.forEach((value, key) => console.log(value, key)); | ||
| console.log(map.size); | ||
|
|
Marc-Andre-Rivet
suggested changes
May 30, 2019
Contributor
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
A few small comments here and there. Otherwise looks good.
| ); | ||
|
|
||
| let isSelectedCell: boolean = selectedCells.some(cell => cell.row === index && cell.column_id === column.id); | ||
| if (isSelectedCell === true) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isSelectedCell === true) { | |
| if (isSelectedCell) { |
The === true is redundant here.
| background-color: var(--selected-background); | ||
| } | ||
|
|
||
Contributor
There was a problem hiding this comment.
I think we can slice out that one ☝️
There's also an entry in Dropdown.css that can be removed (the border-radius is redundant anyway as the border: none is applied elsewhere in that file..
.dash-spreadsheet .cell--selected .Select-control {
background-color: var(--selected-background);
border-radius: 0;
}
| id: 'table', | ||
| editable: true, | ||
| selected_cells: [[1, 1], [1, 2], [1, 3], [2, 1], [2, 2], [2, 3], [3, 1], [3, 2], [3, 3]], | ||
| active_cell: [1, 1], |
Contributor
There was a problem hiding this comment.
Hum.. one has to wonder why these still work 🤔
| ) | ||
| ); | ||
|
|
||
| let isSelectedCell: boolean = selectedCells.some(cell => cell.row === index && cell.column === columnIndex); |
Contributor
There was a problem hiding this comment.
For consistency, use Ramda instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435