Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Border colors rework#402

Closed
valentijnnieman wants to merge 12 commits intomasterfrom
border-colors
Closed

Border colors rework#402
valentijnnieman wants to merge 12 commits intomasterfrom
border-colors

Conversation

@valentijnnieman
Copy link
Copy Markdown
Contributor

@valentijnnieman valentijnnieman commented Mar 22, 2019 •
edited
Loading

This PR aims to replace the way we handle border colors. Still a WIP - pushing up so others can see progress!

Screen Shot 2019-03-22 at 5 29 42 PM

@valentijnnieman
Copy link
Copy Markdown
Contributor Author

valentijnnieman commented Apr 10, 2019 •
edited
Loading

A checklist for border colors visual tests:

  • styling all borders with style_cell
  • styling all borders with style_data
  • styling all borders with style_data, and overriding specific borders with style_data_conditional
  • styling border top, right, bottom, left with style_data_conditional
  • styling border top, right, bottom, left with style_data_conditional, and have "double borders", fighting against each other
  • styling border with style_data_conditional, vertical fighting
  • styling border with style_data_conditional, horizontal fighting
  • styling header cells
  • styling operations
  • styling sections of data, as "viewport"
  • styling the edges of the table, making sure borders work for the first row, last columns, etc

@Marc-Andre-Rivet Marc-Andre-Rivet mentioned this pull request Apr 30, 2019
Merged
6 tasks
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the border-colors branch September 25, 2019 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson will be requested when the pull request is marked ready for review alexcjohnson is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@valentijnnieman @chriddyp