This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Conversation
Marc-Andre-Rivet
suggested changes
Nov 15, 2018
Contributor
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
@T4rk1n This looks fine as far as I can tell.
Could you explain what the component classes are used for? Is this metadata for the IDE?
Otherwise, just need you to update the Changelog and to bump the version to make this PR complete.
Contributor
Author
|
@Marc-Andre-Rivet It's for IDE support, they can read the file instead of being generated at runtime. |
db87a71 to
be86fff
Compare
| rules: [ | ||
| { | ||
| test: /demo[/]index.html?$/, | ||
| test: /demo[/\\]index.html?$/, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the python component loading to generated classes files.
One thing to note,
build:pynow requires dash to be installed on the running python environment.