This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 171 - Rename sorting_settings columnId -> column_id#183
Merged
Marc-Andre-Rivet merged 4 commits intomasterfrom Oct 30, 2018
Merged
Issue 171 - Rename sorting_settings columnId -> column_id#183Marc-Andre-Rivet merged 4 commits intomasterfrom
Marc-Andre-Rivet merged 4 commits intomasterfrom
Conversation
Member
|
Could you also remove the references to the issue in the docs? dash-table/src/dash-table/Table.js Lines 588 to 592 in a70379e |
| @@ -584,16 +584,11 @@ export const propTypes = { | |||
| * For multi-column sorting, this will be a list of | |||
| * sorting parameters, in the order in which they were | |||
| * clicked. | |||
Contributor
Author
There was a problem hiding this comment.
Removing link to 171 as the issue is resolved.
valentijnnieman
approved these changes
Oct 30, 2018
Contributor
valentijnnieman
left a comment
There was a problem hiding this comment.
👍 Just need to fix merge conflicts!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #171