Conversation
|
This is looking pretty good. I left a few TODOs in the code for things that didn't work. @Marc-Andre-Rivet - can you take a look?
|
|
@chriddyp I'll assume "style as a list" is broken as I was not aware of it's existence. For padding I'll see what's happening. |
OK, I recommend taking a thorough look through all of the review apps that I've created and the docs that I've made in https://github.com/plotly/dash-docs/pull/232. There shouldn't be any surprises here! |
| columns=[{'id': c, 'name': c} for c in df.columns], | ||
|
|
||
| # feels odd that I need to specify both of these | ||
| content_style='grow', |
There was a problem hiding this comment.
Yes. Discussed this with @cldougl at some point. As a follow up to the styles work, we are probably capable of knowing if there is a column uses %-based width and make content_style internal at some point.
There was a problem hiding this comment.
does content_style just update some table styles? If so, could we remove content_style from the docs and replace it with a set of CSS styles, e.g.:
style_table={
'width': '100%',
'tableLayout': 'auto'
}
| 'box-shadow': ', '.join([ | ||
| 'inset 0px 1px 0px 0px #CCC', | ||
| 'inset 0px -1px 0px 0px #CCC' | ||
| ]), |
There was a problem hiding this comment.
Apparently box-shadow was not in the list of CSS Properties I picked up from the mozilla page. Will double check and update as needed.
| ]), | ||
|
|
||
| # TODO - This only applies on the headers? | ||
| 'paddingTop': '10px', |
There was a problem hiding this comment.
Should work everywhere. Will investigate what's happening here.
|
Update styling props with #165, will do a second round once merged. |
related to #160, part of #149