Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

107 save on tab -> develop#126

Merged
valentijnnieman merged 7 commits intodevelopfrom
107-save-on-tab
Oct 4, 2018
Merged

107 save on tab -> develop#126
valentijnnieman merged 7 commits intodevelopfrom
107-save-on-tab

Conversation

@valentijnnieman
Copy link
Copy Markdown
Contributor

@Marc-Andre-Rivet Here's the follow-up PR to merge into develop, as you suggested in #122

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-126 October 3, 2018 18:39 Inactive
});

// https://github.com/plotly/dash-table/issues/107
it.only('can edit last and update dataframe on "tab"', () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove .only

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing I missed it in master too? It only impacts local test watch, not the cypress run so it's not too bad :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sugar!

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

@valentijnnieman Once you fix the .only above, this looks good to me

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-126 October 4, 2018 20:44 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-126 October 4, 2018 20:45 Inactive
@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

@valentijnnieman looks good, fire away

Copy link
Copy Markdown
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-126 October 4, 2018 20:53 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants