Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

three new review / documentation / target apps#111

Merged
chriddyp merged 3 commits intodevelopfrom
target-usage-1
Sep 26, 2018
Merged

three new review / documentation / target apps#111
chriddyp merged 3 commits intodevelopfrom
target-usage-1

Conversation

@chriddyp
Copy link
Copy Markdown
Member

#108 but with clean git history

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-111 September 25, 2018 22:35 Inactive
@chriddyp chriddyp changed the base branch from master to develop September 25, 2018 22:35
@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

lgtm!

Copy link
Copy Markdown
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such nice explanations!!


In this way, `min-width` and `overflow-x: scroll` is an alternative
to `text-overflow: ellipses`. With scroll, the content that can't
fit on the container will get pushed out into a scrollable zone.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe fit in the container instead of on

***

`Table` includes several features for modifying and transforming the
view of the data. These include:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing this list is so helpful!!

"""
The widths can be under-specified. Here, we're only setting the width for the three
columns in the middle, the rest of the columns are automatically sized to fit the rest of the container.
The columns have a width of 50, or the width of this line:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps specify 50px in this text (to emphasize the static unit/prepare for variable %s)

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-111 September 26, 2018 19:25 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants