Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Merged column name edits + hidden columns edge case #585

@alexcjohnson

Description

@alexcjohnson

After #578 fixes editing column names in the presence of hidden columns, there's a funny edge case that results:

From one perspective this is a bug: you started with a single header and you edited it, that name should apply to everything the original one applied to. Note that if the hidden column was also named A, all three of them would have been renamed to C, so the editing action depends on invisible properties.

From another perspective, the full table is the authority, and if it doesn't consider the first and third column headers to be merged then why should the edit operation? If we take that perspective, perhaps the real bug is that the two As merged into one header in the first place. They're not adjacent in the full table, so they should not be considered mergeable, regardless of whether the column between them is visible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: Discussion NeededImpacts or is impacted by other issues / parts of the system. Coordination needed.dash-type-bugSomething isn't working as intended

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions