Merged
Conversation
alexcjohnson
reviewed
Sep 1, 2021
| let newHeaders: Record<string, string> | null = null; | ||
| let retry = 0; | ||
|
|
||
| while (true) { |
Collaborator
There was a problem hiding this comment.
while loops always make me uneasy... can this one also be a for like in apiThunk?
Contributor
Author
There was a problem hiding this comment.
✅ Changed to 'for' now. A tad more awkward to get typescript to respect the return type but I agree overall this is better now.
alexcjohnson
reviewed
Sep 1, 2021
alexcjohnson
reviewed
Sep 1, 2021
| request_pre: null, | ||
| request_post: null, | ||
| request_refresh_jwt: null, | ||
| bear: false |
Contributor
Author
There was a problem hiding this comment.
It was there before I got here ¯_(ツ)_/¯ and yes it is unused
Collaborator
There was a problem hiding this comment.
I must be going blind 🙈
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Contributor
Author
|
@alexcjohnson |
alexcjohnson
approved these changes
Sep 2, 2021
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Beautiful. Lovely test! Will merge once ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes dash-renderer refresh the
Authorizationheader with a new JWT provided by therequest_refresh_jwthook, upon a server response indicating that the JWT is expired (401 status, and "JWT Expired" in body).Contributor Checklist
optionals
CHANGELOG.md