There is one percy baseline change. The plotly.py JSON engines always sort object keys in alphabetical order. So the devtools validation exception snapshot changed.

Before:

label/value/typo

After:

label/typo/value in alphabetical order

Ready for review

Oh actually I don't see orjson listed as a dep, were you going to include it in requires-dev.txt? Can we perhaps pick one or two integration tests and run them with both json and orjson? I don't care which, they all make extensive use of JSON encodings :)

Thanks! Yeah, I'll make sure both get used in some tests.

Can we perhaps pick one or two integration tests and run them with both json and orjson? I don't care which, they all make extensive use of JSON encodings :)

Yeah, I added it to requires-dev.txt and made a couple of tests run with both encoders (a167542)

There are also a couple instances of PlotlyJSONEncoder in the tests, do you want to convert these too?

I decided not to as a small extra check for backward compatibility. But it wouldn't take much to talk me into it 🙂

Changelog entry added in (53419b0)

ping @alexcjohnson or @chriddyp. This is ready to merge, but I don't have permission to approve the percy diff mentioned above. Could one of you approve that in percy?

Approved, looks good!

Thanks!