Conversation
d007cd4 to
458618e
Compare
| ributtonExtraClass: "", | ||
|
|
||
| // INPUT CONFIGURATION | ||
| hasAdditionalDates: false, |
There was a problem hiding this comment.
For me allowAdditionalDates woud make more sense, as its in line with the z3c.form widget property.
There was a problem hiding this comment.
I changed to hasAdditionalDates as we already have hasRepeatForeverButton. But is there already a z3c.form widget property which is named allowAdditionalDates? I thought that was introduced in plone/plone.formwidget.recurrence#66
There was a problem hiding this comment.
No there isn't. I just wanted to be them in sync.
|
btw. were the latest two commits on master regarding recurrence widget intended to be in this PR? https://github.com/plone/mockup/commits/master/ |
|
@petschki no, I intentionally left them out of this PR, otherwise reviewing would be hard. This autoformatting did not change anything in the logic, it was just prettifying the code. @petschki what is your opinion again on |
…eview, show a inline warning instead of a window alert.
458618e to
4193b9b
Compare
| yearly: "Yearly", | ||
| }, | ||
|
|
||
| error_load_occurrences: "Cannot load the occurrences preview.", |
There was a problem hiding this comment.
so the translated strings are all provided via the plone.formwidget.recurrence template markup right? This should be implemented there too.
There was a problem hiding this comment.
There was a problem hiding this comment.
@thet do you have an opinion on this? translate the string in the widget or in mockup with widgets.po ?
my personal opinion: I want to allow adding additional dates or not ... so |
4193b9b to
544b3e2
Compare
|
@petschki ok, i agree. I changed it to |
|
@petschki Looks like there are yet no translations. So, let's keep that out. Adding translations to this pattern can be done at any other occasion. |
agreed. since the translations here are done in the widget markup (https://github.com/plone/plone.formwidget.recurrence/blob/master/src/plone/formwidget/recurrence/browser/i18n.py) , we should add it there. |
feat(pat-recurrence): Allow to enable/disable the feature to add additional dates.
Ref:
plone/plone.formwidget.recurrence#66
plone/plone.formwidget.recurrence#49
plone/plone.formwidget.recurrence#48
Translation in: plone/plone.formwidget.recurrence#73
Does two things:
fix(pat-recurrence): In an error case when loading the occurrences preview, show a inline warning instead of a window alert.
before:
after:
feat(pat-recurrence): Allow to enable/disable the feature to add additional dates.
Without (default):
With:
TBD
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #