Conversation
…mports - Add extendViteConfig import and configure optimizeDeps for @nuxt/content/slugify - Update deprecated @nuxt/content/nitro import to @nuxt/content/server - Remove duplicate nuxt-og-image module from modules array - Fix indentation in modules array for consistency This ensures the @pleaseai/docs layer works correctly when imported as a dependency in other Nuxt projects.
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the compatibility and maintainability of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses compatibility issues for the @pleaseai/docs Nuxt layer, ensuring it works correctly as a dependency. The changes include removing a duplicate module, fixing formatting inconsistencies, and adding necessary Vite configuration for @nuxt/content dependencies. The core logic is sound. I have provided one suggestion to enhance the robustness and readability of the new Vite configuration logic in nuxt.config.ts.
Deploying docs-please with
|
| Latest commit: |
0de7342
|
| Status: | ⚡️ Build in progress... |
|
Summary
This PR ensures the
@pleaseai/docslayer works correctly when imported as a dependency in other Nuxt projects by fixing @nuxt/content compatibility issues.Changes
@nuxt/content/nitrowith@nuxt/content/server(deprecated in newer @nuxt/content versions)nuxt-og-imageentry in modules arrayTest Plan
cd packages/layer && bun buildcd packages/layer && bun typecheckbun build(from root)extends: ['@pleaseai/docs']works correctly