Apply recommendations from Pekko 1.1.x Migration guide#12793
Merged
mkurz merged 1 commit intoplayframework:mainfrom Jul 8, 2024
Merged
Apply recommendations from Pekko 1.1.x Migration guide#12793mkurz merged 1 commit intoplayframework:mainfrom
mkurz merged 1 commit intoplayframework:mainfrom
Conversation
Member
|
Thanks @gwak, can you please run |
mkurz
reviewed
Jul 8, 2024
https://pekko.apache.org/docs/pekko/1.1.0-M1/migration/migration-guide-1.0.x-1.1.x.html Reformatting Keep underscores for now.
4e50cbc to
1f331df
Compare
Member
|
Thanks! |
This was referenced Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Purpose
This PR applies the recommendations from the Pekko migration guide from 1.0.x to 1.1.x. The Pekko sub stream cancellation strategy was defaulted to
SubstreamCancelStrategy.drainin the 1.0.x branches. It now defaults toSupervision.stopwhich is an equivalent ofSubstreamCancelStrategy.propagate. It causes the MultipartFormData parser to fail after the firstform-dataitem encountered when using Pekko 1.1.x dependencies in user land.Background Context
The change doesn't affect Play 3.0.4 users using the Pekko 1.0.x dependencies included with the framework it self. But it gets the framework ready for when the Pekko 1.1.x release is ready. It has the added benefit of making the usage of the "cancel on purpose as an early sub-stream exit" pattern more obvious.
References
Migration from Apache Pekko 1.0.x to 1.1.x
A PR from @pjfanning trying the Pekko 1.1.0-M1 release in Play 3 bringing those changes as well