Do not run tests with Java 8 anymore#11435
Conversation
| }, | ||
| "--release", | ||
| "11", | ||
| ), |
There was a problem hiding this comment.
The --release flag replaces the -source, -target and -bootclasspath flags. See https://stackoverflow.com/a/43103038/810109
|
|
||
| val isJdk11orHigher: Boolean = | ||
| VersionNumber(specificationVersion).matchesSemVer(SemanticSelector(">=11")) | ||
|
|
There was a problem hiding this comment.
No need anymore for these methods (they were unused anyway)
| } | ||
| Seq("-source", "8", "-target", "8", "-bootclasspath", s"$javaHome/jre/lib/rt.jar") | ||
| } | ||
| } |
There was a problem hiding this comment.
Same here, sourceAndTarget is not need anymore now.
da6ffde to
8f7db7e
Compare
| .settings(omnidocSettings: _*) | ||
| .settings( | ||
| scalacOptions += "-target:jvm-1.8" | ||
| scalacOptions += "-release:11" |
There was a problem hiding this comment.
IMHO we should use release here instead of target (release was only available with Java 9).
Also, good thing is -release got fixed in Scala 2.13.9 and now works the same way like in Scala 3 (where it is an alias for -java-output-version) Also, it's recommended to use it instead of target by scala devs. Makes sense for me.
8f7db7e to
3b141a3
Compare
|
Blocked by etorreborre/specs2#1103 |
Because interplay sets Scala version to 2.12.17 with comes with scala-xml 2
07192f4 to
8412471
Compare
e5c5285 to
c0d35b0
Compare
a1982eb to
ddf6041
Compare
This is a workaround until a new sbt version gets released that finally comes with Scala 2.12.17
ddf6041 to
7d48e8d
Compare
|
Finally, after going through scala-xml dependency hell. |
Java 17 will be added in a different PR.
This is just so we can finally upgrade many dependencies that now require Java 11+