Skip to content
This repository was archived by the owner on Apr 23, 2019. It is now read-only.

Add jdk 10 & 11 to Travis build#86

Merged
marcospereira merged 7 commits intoplayframework:2.6.xfrom
marcospereira:add-jdk-10-11
Jun 8, 2018
Merged

Add jdk 10 & 11 to Travis build#86
marcospereira merged 7 commits intoplayframework:2.6.xfrom
marcospereira:add-jdk-10-11

Conversation

@marcospereira
Copy link
Member

Checking if travis-ci/travis-build#1347 is already available to all repositories. :-)

@sormuras
Copy link

...should work. 🤞

@sormuras
Copy link

The JDKs were installed correctly. ✔️

Now there are some modular world issues... :-)

@wsargent
Copy link
Member

Now there are some modular world issues... :-)

Have you tried turning it off and on again?

@sormuras
Copy link

sormuras commented May 30, 2018

Have you tried turning it off and on again?

Huh? Okay, it took some time. 😃

Looks like sbt doesn't like JDK 10 or 11. Same goes for Gradle and JDK 11.

For example: https://travis-ci.org/playframework/play-scala-starter-example/jobs/385785029#L1002

javax.xml.bind.DatatypeConverter is missing. Smells like some "--add-modules" love is needed.

@mkurz
Copy link
Member

mkurz commented May 30, 2018

sbt 1.1.6 ist tagged already

@marcospereira
Copy link
Member Author

Looks like Gradle is getting there: gradle/gradle#4515

javax.xml.bind.DatatypeConverter is missing. Smells like some "--add-modules" love is needed.

Yeah, the last commit here should fix this.

@marcospereira
Copy link
Member Author

sbt 1.1.6 ist tagged already

Add a new commit to use it.

@marcospereira
Copy link
Member Author

Same goes for Gradle and JDK 11.

Update to Gradle 4.7 which I think contains a fix for this. :-)

@sormuras
Copy link

Gradle 4.7 fixed Java 10 issue. Gradle 4.8 tackles Java 11 ones. Try 4.8-rc-2 (or -3)

@marcospereira
Copy link
Member Author

marcospereira commented May 30, 2018

The last commit should make the build pass:

9c249a2

/cc @schmitch ☝️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants