Skip to content

fix field ordering Scala 3 writes macro#1172

Merged
mkurz merged 1 commit intoplayframework:mainfrom
xuwei-k:scala-3-writes-field-order
Jun 30, 2025
Merged

fix field ordering Scala 3 writes macro#1172
mkurz merged 1 commit intoplayframework:mainfrom
xuwei-k:scala-3-writes-field-order

Conversation

@xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jun 14, 2025

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Purpose

use Seq instead of Map and sort by field index in macro

Background Context

References

@xuwei-k xuwei-k marked this pull request as ready for review June 14, 2025 00:59
@xuwei-k xuwei-k force-pushed the scala-3-writes-field-order branch from c5580b0 to 68c2665 Compare June 14, 2025 01:06
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable!

@mkurz mkurz merged commit 0793c1b into playframework:main Jun 30, 2025
14 checks passed
@mkurz
Copy link
Member

mkurz commented Jun 30, 2025

@Mergifyio backport 3.0.x 2.10.x

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2025

backport 3.0.x 2.10.x

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON field ordering bug with Scala 3

2 participants