try to avoid reparsing numbers as BigDecimal when serializing#1073
Closed
pjfanning wants to merge 1 commit intoplayframework:mainfrom
Closed
try to avoid reparsing numbers as BigDecimal when serializing#1073pjfanning wants to merge 1 commit intoplayframework:mainfrom
pjfanning wants to merge 1 commit intoplayframework:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes #xxxx
Purpose
What does this PR do?
Parsing numbers from strings is expensive. This PR covers one case where a BigDecimal is converted to a String (expensive too) and then parsed again as a BigDecimal. This PR skips the final parse and just uses the BigDecimal instance that we already have.
Background Context
Why did you take this approach?
References
Are there any relevant issues / PRs / mailing lists discussions?