feat: add activate event to GridView on Enter key press#511
Merged
Conversation
Made-with: Cursor
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an activate event to the GridView component that triggers when users press Enter on a focused GridViewItem or double-click on one. This follows established UI toolkit patterns (GTK, Qt, WPF) where activation is a distinct intent-level event separate from selection. The implementation mirrors the event constant and documentation patterns used by TreeView in this codebase.
Changes:
- Added
EVENT_ACTIVATEconstant with JSDoc documentation following codebase conventions - Extended keydown handler to recognize Enter key and emit the activate event
- Added double-click handler to emit the same activate event
- Updated destroy method to properly clean up the new double-click event listener
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activateevent toGridViewthat fires when the user presses Enter on a focusedGridViewItemor double-clicks oneEVENT_*constant and@eventJSDoc pattern used byTreeViewTest plan
GridViewwith items and listen for theactivateeventGridViewItemactivateevent fires<input>element inside a grid itemEVENT_ACTIVATEconstant appears in TypeDoc output