feat: expose content getter on TreeViewItem#507
Merged
Conversation
Made-with: Cursor
7809865 to
c5ecdcf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a public content getter to the TreeViewItem class to expose the internal _containerContents container. This eliminates the need for unsafe type assertions when accessing this container from external code, particularly the Editor which previously accessed it via (treeItem as TreeViewItem & { _containerContents: Container })._containerContents.dom.
Changes:
- Added a
contentgetter onTreeViewItemthat returns_containerContentswith JSDoc documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentgetter onTreeViewItemthat returns the internal_containerContentscontainerDetails
The Editor currently accesses
_containerContentsvia an unsafe type assertion:The new getter provides clean public access:
The getter is named
contentfor consistency withPanel.content, which follows the same pattern of exposing an internal content container.Test plan
npm run build)npm test)npm run lint)