Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: playcanvas/pcui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.0.0
Choose a base ref
...
head repository: playcanvas/pcui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 2, 2026

  1. fix: validate active item after GridView filtering (#515)

    * fix: validate active item after GridView filtering
    
    When filtering hides the current active item (the one with tabIndex=0),
    no visible item remains tabbable, breaking Tab key navigation.
    
    Add _validateActiveItem() to reassign the roving tabIndex to the first
    visible item after each filter batch, matching the Table's existing
    _validateActiveRow() pattern.
    
    Made-with: Cursor
    
    * Address review feedback
    
    - Use _setActiveItem(null) instead of manual tabIndex/null mutation
    - Add destroyed check to _validateActiveItem early return
    - Reuse _validateActiveItem in _onRemoveGridViewItem
    - Add unit tests for filter() and filterAsync() active item reassignment
    
    Made-with: Cursor
    
    * Optimize filterAsync to only validate when active item is hidden
    
    Track whether the active item was hidden during the current batch and
    only call _validateActiveItem() when needed, avoiding a full DOM scan
    on every frame for large grids.
    
    Made-with: Cursor
    willeastcott authored Mar 2, 2026
    Configuration menu
    Copy the full SHA
    230799b View commit details
    Browse the repository at this point in the history
  2. 6.0.1

    willeastcott committed Mar 2, 2026
    Configuration menu
    Copy the full SHA
    6c1518d View commit details
    Browse the repository at this point in the history
Loading