[FIX] Fix ElementComponent 'mousemove' event firing outside element#8288
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where mousemove events incorrectly continued firing on an ElementComponent after the mouse cursor moved outside its bounds while the left button was pressed. The fix restores the expected behavior where mousemove events only fire on the element currently under the cursor.
Key Changes:
- Modified event capture logic to only apply to
mouseupevents, notmousemove - Updated inline comment to reflect the narrower scope of event capture
- Maintains proper click detection by keeping
mouseupcapture behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Dec 20, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4755
Overview
When the left mouse button was pressed inside an ElementComponent,
mousemoveevents would continue to fire on that element even after the mouse cursor moved outside its bounds. This was a regression from engine version 1.55.0.Changes
mousemoveevents now only fire on the element currently under the mouse cursormouseupevents still fire on the originally pressed element to maintain proper click detectionmouseenter/mouseleaveevents continue to work correctly for hover state trackingTechnical Details
The
_onElementMouseEventmethod was incorrectly "capturing" bothmousemoveandmouseupevents when an element was pressed. This capture behavior is only needed formouseupto properly detect clicks (comparing pressed element vs hovered element).The fix changes the condition from:
to:
This ensures
mousemoveis only dispatched to the element the cursor is actually over, whilemouseupcontinues to be dispatched to the pressed element for click detection logic.Demonstration of Fix
mousemove-bug.mp4
Checklist