Skip to content

Remove masking examples#2797

Merged
willeastcott merged 1 commit into
masterfrom
remove-masking-examples
Jan 29, 2021
Merged

Remove masking examples#2797
willeastcott merged 1 commit into
masterfrom
remove-masking-examples

Conversation

@willeastcott

Copy link
Copy Markdown
Contributor

The UI masking examples located in examples/masking have never been exposed on playcanvas.github.io. They are completely non-obvious in what they are showing. This PR deletes the examples. Instead, we should submit a subsequent PR that introduces clear, good-looking examples that illustrate the UI masking feature.

I confirm I have signed the Contributor License Agreement.

@willeastcott willeastcott requested a review from a team January 29, 2021 11:46
@willeastcott willeastcott self-assigned this Jan 29, 2021
@willeastcott willeastcott changed the title Remove masking example Remove masking examples Jan 29, 2021
@mvaligursky

Copy link
Copy Markdown
Contributor

Perhaps create a new issue and link it to this, so that we have code reference.

@willeastcott willeastcott merged commit 78eec78 into master Jan 29, 2021
@willeastcott willeastcott deleted the remove-masking-examples branch January 29, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui UI related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants