extract assignment outside loop

shlomi-noach · shlomi-noach · commit 00a1bf39f399 · 2025-04-27T08:22:15.000+03:00
Signed-off-by: Shlomi Noach &lt;2607934+shlomi-noach@users.noreply.github.com&gt;
diff --git a/go/mysql/replication/mysql56_gtid_set.go b/go/mysql/replication/mysql56_gtid_set.go
@@ -425,9 +425,8 @@ func (set Mysql56GTIDSet) AddGTIDInPlace(gtid GTID) GTIDSet {
 			// Can't be merged.
 			newIntervals = append(newIntervals, iv)
 		}
-
-		set[gtid56.Server] = newIntervals
 	}
+	set[gtid56.Server] = newIntervals
 
 	if !added {
 		// There wasn't any place to insert the new GTID, so just append it

Original file line number	Diff line number	Diff line change
`@@ -425,9 +425,8 @@ func (set Mysql56GTIDSet) AddGTIDInPlace(gtid GTID) GTIDSet {`
`425`	`425`	`// Can't be merged.`
`426`	`426`	`newIntervals = append(newIntervals, iv)`
`427`	`427`	`}`
`428`		`-`
`429`		`- set[gtid56.Server] = newIntervals`
`430`	`428`	`}`
	`429`	`+ set[gtid56.Server] = newIntervals`
`431`	`430`
`432`	`431`	`if !added {`
`433`	`432`	`// There wasn't any place to insert the new GTID, so just append it`