Closed
Conversation
Closed
tzerrell
previously approved these changes
Nov 9, 2020
tzerrell
left a comment
There was a problem hiding this comment.
LGTM, I have some optional suggestions inline.
|
|
||
| namespace PlaidMLPlugin { | ||
|
|
||
| edsl::Tensor clip_activation(const std::string& func_name, bool should_clip, float clip, const edsl::Tensor& T) { |
There was a problem hiding this comment.
As discussed in #102, let's follow your suggestion and move this to plaidml_util
Comment on lines
+50
to
+51
| auto activations_alpha = layer->get_activations_alpha(); | ||
| auto activations_beta = layer->get_activations_beta(); |
There was a problem hiding this comment.
I believe these are unused with current activations
tzerrell
approved these changes
Nov 10, 2020
Merged
|
Obsolete -- this same code (plus merge conflict fixes) was landed as #109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.