Regroup marshling/unmarshaling and lint#456
Conversation
|
I should run a regression test on this with FileZilla… since I’m touching the |
|
Hi, I just tested with FileZilla and it seems ok. SFTPGo test cases also passed. I'm not sure about UIDs/GIDs to usernames and groupnames conversion, however we may allow you to override the conversion in the future if needed. Thanks! |
|
The directory listing is now something like this
|
|
Yeah, I was thinking of abstracting it away to an optional interface as well. It shouldn’t be too hard. 🤔 |
|
I’ve spun off the username and groupname lookup into an extension type on |
|
it looks good for me, thanks |
This covers a few different things that were somewhat unrelated to starting to use
filexferbut will make that transfer easier.packets.goclampandminfunctions that both did the same thing, and didn’t really contribute to more understandable code.os.ModeType → uint32where we treat the various types as bitfields that can be OR’ed together rather than mutually exclusive values.request-server.gofileInfocan use the values in the wrappedFileStat, which we also don’t need to treat as anany.ls_formattingfrom PR-432, as this is an improvement beyond just bringing infilexferas it extracts more UID/GID values for the variousGOOS, supports setting UID/GID values from aFileStat, and also converts UIDs/GIDs to usernames and groupnames when possible. (Do we really want to use system-wide username/groupnames? Might be good to provide an ability to override this? Sincerequest-servermight be operating entirely disjoint from the underlying OS.)cgobuild conditions that were not actually necessaryGOOSsupported ingo1.16(not verified that it works, just that it compiles)