Skip to content

Refactor code directory structure#3

Merged
mattmoreira merged 16 commits intomasterfrom
feature/refactor-code-structure
Aug 24, 2020
Merged

Refactor code directory structure#3
mattmoreira merged 16 commits intomasterfrom
feature/refactor-code-structure

Conversation

@mattmoreira
Copy link
Copy Markdown
Collaborator

@mattmoreira mattmoreira commented Aug 4, 2020 •
edited
Loading

Moved typescript code from codemod/output to src, and rearranged the files into src

New directory structure:

image

@mattmoreira
Copy link
Copy Markdown
Collaborator Author

mattmoreira commented Aug 5, 2020

@jakubzitny, @TheWiseNoob and @mtltechtemp, this is the PR I've mentioned, can you please review it?

mtltechtemp
mtltechtemp approved these changes Aug 16, 2020
View reviewed changes
Copy link
Copy Markdown

@mtltechtemp mtltechtemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for me!

@jakubzitny
Copy link
Copy Markdown

jakubzitny commented Aug 16, 2020

I like it.. looks good, but let me try to test it a bit ;)

@mattmoreira
Copy link
Copy Markdown
Collaborator Author

mattmoreira commented Aug 22, 2020

@jakubzitny, were you able to test it?

jakubzitny
jakubzitny approved these changes Aug 24, 2020
View reviewed changes
Copy link
Copy Markdown

@jakubzitny jakubzitny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for delays. I'm quite overloaded with a lot of different work. Let's merge it and maybe update the upstream PR? Any maybe release beta version so more people can test it as well?

Do you guys use this in a production system somewhere as well?

@mattmoreira
Copy link
Copy Markdown
Collaborator Author

mattmoreira commented Aug 24, 2020

No worries @jakubzitny! I don't use it in a production system, however, I used to use in my last company, I can ask them to test it and see how it goes.

@mattmoreira mattmoreira merged commit 8a498e7 into master Aug 24, 2020
@jakubzitny
Copy link
Copy Markdown

jakubzitny commented Aug 25, 2020

No worries @jakubzitny! I don't use it in a production system, however, I used to use in my last company, I can ask them to test it and see how it goes.

That would be awesome, I'll release the upstream PR as a beta version and if your ex-colleagues can test it, that would be awesome. The thing is that I still don't have the access to evaporate on NPM. So I'll create a new package and share it here 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jakubzitny jakubzitny jakubzitny approved these changes

@mtltechtemp mtltechtemp mtltechtemp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattmoreira @jakubzitny @mtltechtemp