Fix #13: Add option -r to select a random cow#30
Merged
piuccio merged 3 commits intopiuccio:masterfrom Mar 27, 2018
Merged
Conversation
piuccio
reviewed
Oct 25, 2017
Owner
piuccio
left a comment
There was a problem hiding this comment.
Code looks good, il can't wait test it properly cause I'm on vacation this week.
Do you mind checking the indentation and maybe implement the browser version?
Thanks for contributing
Contributor
Author
|
Sure! I'll look into it tonight. |
Contributor
Author
|
Hi, I fixed the indentation. Still working on the browser version. I'm not sure if it's possible without braking the tree-shaking possibility, since I'll have to import all cows to randomize between them. |
Owner
|
That's true, let's leave it for now, it's quite easy to implement random
cows client side
…On Thu, 26 Oct 2017, 21:49 Douglas Matoso, ***@***.***> wrote:
Hi, I fixed the indentation.
Still working on the browser version. I'm not sure if it's possible
without braking the tree-shaking possibility, since I'll have to import all
cows to randomize between them.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAphXJHqraQXV-6jWS8fTWnOUgDKKeW4ks5swH_TgaJpZM4QE4rz>
.
|
Owner
|
Sorry I completely forgot about this, released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added -r option just for CLI. I could try adding for the browsers also, if that's desirable.