add test for float32; specify namespace of trunc

pprudhvi · pprudhvi · commit aa02da53ff50 · 2019-07-17T16:09:22.000+05:30
diff --git a/cpp/src/gandiva/precompiled/arithmetic_ops.cc b/cpp/src/gandiva/precompiled/arithmetic_ops.cc
@@ -202,7 +202,7 @@ DIV(int64)
       gdv_fn_context_set_error_msg(context, err_msg);           \
       return 0;                                                 \
     }                                                           \
-    return static_cast<TYPE>(trunc(in1 / in2));                 \
+    return static_cast<TYPE>(::trunc(in1 / in2));               \
   }
 
 DIV_FLOAT(float32)
diff --git a/cpp/src/gandiva/precompiled/arithmetic_ops_test.cc b/cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
@@ -79,16 +79,22 @@ TEST(TestArithmeticOps, TestDiv) {
   EXPECT_EQ(div_int64_int64(reinterpret_cast<int64>(&context), 101, 111), 0);
   EXPECT_EQ(context.has_error(), false);
   context.Reset();
-  
-  EXPECT_EQ(div_float64_float64(reinterpret_cast<int64>(&context), 1010.1010, 2.1), 481.0);
+
+  EXPECT_EQ(div_float64_float64(reinterpret_cast<int64>(&context), 1010.1010, 2.1),
+            481.0);
   EXPECT_EQ(context.has_error(), false);
   context.Reset();
-  
-  EXPECT_EQ(div_float64_float64(reinterpret_cast<int64>(&context), 1010.1010, 0.00000), 0.0);
+
+  EXPECT_EQ(div_float64_float64(reinterpret_cast<int64>(&context), 1010.1010, 0.00000),
+            0.0);
   EXPECT_EQ(context.has_error(), true);
   EXPECT_EQ(context.get_error(), "divide by zero error");
   context.Reset();
-  
+
+  EXPECT_EQ(div_float32_float32(reinterpret_cast<int64>(&context), 1010.1010f, 2.1f),
+            481.0f);
+  EXPECT_EQ(context.has_error(), false);
+  context.Reset();
 }
 
 }  // namespace gandiva
diff --git a/cpp/src/gandiva/precompiled/types.h b/cpp/src/gandiva/precompiled/types.h
@@ -126,6 +126,7 @@ float64 mod_float64_float64(int64 context, float64 left, float64 right);
 int64 divide_int64_int64(int64 context, int64 in1, int64 in2);
 
 int64 div_int64_int64(int64 context, int64 in1, int64 in2);
+float32 div_float32_float32(int64 context, float32 in1, float32 in2);
 float64 div_float64_float64(int64 context, float64 in1, float64 in2);
 
 float64 cbrt_int32(int32);

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ DIV(int64)`
`202`	`202`	`gdv_fn_context_set_error_msg(context, err_msg); \`
`203`	`203`	`return 0; \`
`204`	`204`	`} \`
`205`		`- return static_cast<TYPE>(trunc(in1 / in2)); \`
	`205`	`+ return static_cast<TYPE>(::trunc(in1 / in2)); \`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`DIV_FLOAT(float32)`