v2: read length and skip the bytes for UNSPEC#62
Merged
pires merged 1 commit intopires:mainfrom Jan 20, 2021
bohanwood:unspec-zero-length
Merged
v2: read length and skip the bytes for UNSPEC#62pires merged 1 commit intopires:mainfrom bohanwood:unspec-zero-length
pires merged 1 commit intopires:mainfrom
bohanwood:unspec-zero-length
Conversation
pires
reviewed
Jan 19, 2021
Owner
pires
left a comment
There was a problem hiding this comment.
One last thing and I think we're good to go. Thank you very much for your patience and contribution!
pires
reviewed
Jan 20, 2021
Author
|
Just found that there're two tests with desc |
Owner
|
Nice catch! Please, fix the desc of the last one which is clearly a test for TCPv6. |
Author
|
Done! |
pires
approved these changes
Jan 20, 2021
Owner
pires
left a comment
There was a problem hiding this comment.
What a great contribution! Thank you very much, @bohanyang
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61 (comment)