Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
+ Coverage 78.00% 78.47% +0.46%
==========================================
Files 89 89
Lines 10582 11037 +455
==========================================
+ Hits 8255 8661 +406
- Misses 1838 1890 +52
+ Partials 489 486 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sean-Der
reviewed
Jan 2, 2025
Member
|
Amazing! This is exactly what we need @joeturki If you are overwhelmed by the lints you can just upgrade versions/disable more and we can iterate on it! |
Sean-Der
reviewed
Jan 2, 2025
875f2bb to
37cc0f4
Compare
Introduces new linters, upgrade golangci-lint to version (v1.63.4)
b5559ee to
feeeebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the linters, I will ignore those that require refactor (will be addressed in a separate PR).
Reference PR
pion/.goassets#220