Skip to content

Upgrade golangci-lint, more linters#432

Merged
JoTurk merged 1 commit intomasterfrom
update/lint
Jan 11, 2025
Merged

Upgrade golangci-lint, more linters#432
JoTurk merged 1 commit intomasterfrom
update/lint

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Jan 11, 2025

Description

This PR introduces new linters and resolves issues with the latest golangci-lint version (v1.63.4).

Reference issue

pion/.goassets#220

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.45182% with 152 lines in your changes missing coverage. Please review.

Project coverage is 66.14%. Comparing base (7a3d4d2) to head (5b58083).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/turn.go 59.77% 54 Missing and 16 partials ⚠️
internal/server/server.go 31.25% 21 Missing and 1 partial ⚠️
internal/server/util.go 51.61% 10 Missing and 5 partials ⚠️
lt_cred.go 50.00% 12 Missing ⚠️
internal/client/udp_conn.go 82.22% 7 Missing and 1 partial ⚠️
client.go 50.00% 6 Missing ⚠️
internal/client/allocation.go 16.66% 5 Missing ⚠️
relay_address_generator_range.go 0.00% 4 Missing ⚠️
server.go 85.00% 3 Missing ⚠️
internal/allocation/allocation.go 92.30% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   66.94%   66.14%   -0.80%     
==========================================
  Files          43       43              
  Lines        2919     3084     +165     
==========================================
+ Hits         1954     2040      +86     
- Misses        801      877      +76     
- Partials      164      167       +3
Flag Coverage Δ
go 66.14% <67.45%> (-0.80%) ⬇️
wasm 26.58% <15.41%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoTurk JoTurk marked this pull request as draft January 11, 2025 09:48
@JoTurk JoTurk force-pushed the update/lint branch 2 times, most recently from a8e23f8 to 3252890 Compare January 11, 2025 09:52
JoTurk
JoTurk commented Jan 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (triple-reviewed it)!

@JoTurk JoTurk marked this pull request as ready for review January 11, 2025 10:39
@JoTurk JoTurk merged commit 54b9d20 into master Jan 11, 2025
@JoTurk JoTurk deleted the update/lint branch January 11, 2025 10:55
@JoTurk JoTurk mentioned this pull request Jan 11, 2025
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JoTurk