Skip to content

Update lint rules, use testify/assert#309

Merged
RyanPotat merged 1 commit intomasterfrom
RyanPotat/lint/test-helpers
Mar 24, 2025
Merged

Update lint rules, use testify/assert#309
RyanPotat merged 1 commit intomasterfrom
RyanPotat/lint/test-helpers

Conversation

@RyanPotat
Copy link
Copy Markdown
Member

Description

Update lint rules to forbid the use of direct testing.T helpers.

pion/.goassets/pull/222

Reference issue

N/A

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.14%. Comparing base (a108bbd) to head (b7fb3b5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files          17       17           
  Lines        1539     1539           
=======================================
  Hits         1218     1218           
  Misses        219      219           
  Partials      102      102           
Flag Coverage Δ
go 79.14% <100.00%> (ø)
wasm 78.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch from f20c6f8 to b7fb3b5 Compare March 24, 2025 04:20
Copy link
Copy Markdown
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@RyanPotat RyanPotat merged commit b7fb3b5 into master Mar 24, 2025
15 checks passed
@RyanPotat RyanPotat deleted the RyanPotat/lint/test-helpers branch March 24, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants