Skip to content

Add adaptive burst mitigation #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philipch07 merged 2 commits into from
Dec 23, 2025
Merged

Add adaptive burst mitigation #394

philipch07 merged 2 commits into from
Dec 23, 2025
+790 −66

Conversation

@philipch07
Copy link
Contributor

@philipch07 philipch07 commented Oct 7, 2025 •
edited
Loading

Description

Adds adaptive burst mitigation as described in section 5A of RACK for SCTP (https://icnp20.cs.ucr.edu/proceedings/nipaa/RACK%20for%20SCTP.pdf).

Also relaxes the deadlines from #408 to go from 10 seconds (old) -> 15 seconds (new). For some reason it's inconsistent on the runners :(

Reference issue

Closes #395

@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.11588% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.04%. Comparing base (fa1ba4c) to head (8b5d2bf).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
association.go 81.11% 25 Missing and 19 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   84.23%   84.04%   -0.19%     
==========================================
  Files          52       52              
  Lines        3767     3948     +181     
==========================================
+ Hits         3173     3318     +145     
- Misses        444      465      +21     
- Partials      150      165      +15
Flag Coverage Δ
go 84.04% <81.11%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@philipch07

This comment was marked as resolved.

Sign in to view
@philipch07 philipch07 mentioned this pull request Oct 22, 2025
Merged
@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch 5 times, most recently from bfd30d3 to 533950c Compare October 28, 2025 02:02
@JoTurk JoTurk requested a review from Copilot November 2, 2025 05:11

This comment was marked as outdated.

Sign in to view

@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch 2 times, most recently from 61741b9 to a7af7ac Compare November 2, 2025 05:34
@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch 4 times, most recently from 7d27f29 to ceb98e5 Compare November 11, 2025 04:57
@JoTurk
Copy link
Member

JoTurk commented Nov 11, 2025 •
edited
Loading

After yesterday changes it's much better, l'll update the results either tonight or tomorrow, hopefully we have it on the CI too.

@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch from ceb98e5 to 0717fb2 Compare November 11, 2025 21:20
JoTurk
JoTurk approved these changes Nov 23, 2025
View reviewed changes
Copy link
Member

@JoTurk JoTurk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, especially with the rack branch.

Great work :)

@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch 3 times, most recently from abef532 to df108cb Compare December 22, 2025 07:33
@philipch07
Copy link
Contributor Author

philipch07 commented Dec 22, 2025

@joeturki's testing with SCP revealed that my original implementation did fine in tests where it connected to master and RACK, but it had issues when connecting to itself. As a result, I rewrote my approach (which is somewhat simpler now) and is now also based on the RACK branch.

@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch 2 times, most recently from 8b1e40f to 629f928 Compare December 23, 2025 03:35
@philipch07 philipch07 force-pushed the pch07/adaptive-burst-mitigation branch from 629f928 to 8b5d2bf Compare December 23, 2025 18:03
@philipch07 philipch07 merged commit a5107c6 into master Dec 23, 2025
48 of 53 checks passed
@philipch07 philipch07 deleted the pch07/adaptive-burst-mitigation branch December 23, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JoTurk JoTurk JoTurk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add adaptive burst mitigation

3 participants

@philipch07 @JoTurk