Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 81.95% 81.84% -0.12%
==========================================
Files 51 51
Lines 4539 4539
==========================================
- Hits 3720 3715 -5
- Misses 677 680 +3
- Partials 142 144 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thank you so much ryan <3 |
JoTurk
reviewed
Mar 22, 2025
Member
JoTurk
left a comment
There was a problem hiding this comment.
This is great! Thank you so much, Ryan, for your help with this. Just a few minor issues: it replaces t.Errorf with assert.Error, but it should use assert.ErrorF for formatted messages
18 tasks
1364d5e to
5690def
Compare
Member
Author
|
@joeturki I made all your corrections, and found a few more as well. 👍 |
5690def to
f033190
Compare
Member
Author
|
@joeturki Fixed! 😎 |
corrections
f033190 to
24efa50
Compare
JoTurk
approved these changes
Mar 22, 2025
Member
|
Thank you Ryan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use testify/assert in place of the standard testing package, and update where applicable to use
assert.NoErrorpion/.goassets/pull/222
Reference issue
N/A