Skip to content

Adopt testify/assert for all tests#298

Merged
JoTurk merged 1 commit intomasterfrom
lint/test-helpers
Mar 21, 2025
Merged

Adopt testify/assert for all tests#298
JoTurk merged 1 commit intomasterfrom
lint/test-helpers

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Mar 5, 2025

Description

Use testify's assert package instead of the standard library's testing package.

pion/.goassets#222

Reference issue

resolve #297

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (9bbc0f6) to head (fe7fcf6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          26       26           
  Lines        3061     3061           
=======================================
  Hits         2656     2656           
  Misses        348      348           
  Partials       57       57           
Flag Coverage Δ
go 86.76% <ø> (ø)
wasm 86.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk force-pushed the lint/test-helpers branch from 223932a to 5f28ee0 Compare March 5, 2025 00:32
@Sean-Der
Copy link
Copy Markdown
Member

Sean-Der commented Mar 5, 2025

Screenshot 2025-03-04 at 4 56 53 PM

Love that red diff :)

@JoTurk JoTurk force-pushed the lint/test-helpers branch from 5f28ee0 to bab3927 Compare March 9, 2025 21:50
@JoTurk JoTurk marked this pull request as ready for review March 9, 2025 21:51
@JoTurk JoTurk force-pushed the lint/test-helpers branch 2 times, most recently from 8d073e3 to 60ef99e Compare March 9, 2025 23:43
Use testify's assert package instead of the standard library's testing
package.
@JoTurk JoTurk force-pushed the lint/test-helpers branch 4 times, most recently from f04cc06 to fe7fcf6 Compare March 21, 2025 03:05
@JoTurk JoTurk merged commit fe7fcf6 into master Mar 21, 2025
15 checks passed
@JoTurk JoTurk deleted the lint/test-helpers branch March 21, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt testify for tests

2 participants