Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.96%. Comparing base (cd52e6b) to head (feba4d2).
Report is 2 commits behind head on master.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   83.71%   83.96%   +0.25%     
==========================================
  Files          24       24              
  Lines        2450     2514      +64     
==========================================
+ Hits         2051     2111      +60     
- Misses        340      343       +3     
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This looks perfect! I will fix linter and merge tonight :)

excited to use ir

Thanks for the PR. It would be helpful to have a payloader implementation for H.265. However, I prefer #165 because it has a fragment aggregation packet implementation and can transmit more efficiently.

Thanks for the PR. It would be helpful to have a payloader implementation for H.265. However, I prefer #165 because it has a fragment packet implementation and can transmit more efficiently.

Thanks for the comment. I actually missed #165, when started working on my payloader. However it looks pretty stalled on the test adding stage. And this one already has tests and is confirmed to work in browser (see attach).
I can see 3 options here:

1. Merge this one
2. Close this PR, so Add H265 payloader and depacketizer #165 can be finished and merged
3. I can try to move some missing features from Add H265 payloader and depacketizer #165 to this one

So, I guess its up to @Sean-Der to decide :)

@z1rachl
Thanks for the response. I have confirmed that I can play it in Safari using #287 with minor bug fixes from #165, Chrome is still checking. (I am checking which future flag to enable).

I have confirmed that it works on chrome . So functionality and whether #165 still has the motivation to move forward with PR will be the determining factor.

Hello! We’re working on updating the linters[1], Sorry I caused conflicts on your branch, Would you like me to fix the conflicts and fix the lint issues on your branch?

Thank you so much for your work! <3

#288

Closed in favor of #287