Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 71.13% 71.14%
=======================================
Files 80 80
Lines 4476 4477 +1
=======================================
+ Hits 3184 3185 +1
Misses 1157 1157
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
63459d3 to
33c0388
Compare
Contributor
Author
|
I'm not sure what's going on with the linter - it doesn't seem to mention the offenders. I tried to fix some locations where newline was added but the linter still isn't passing. |
Contributor
|
Thanks @sterlingdeng . I opened #288 and pion/.goassets#218, which should clear the linter problem. Let's wait for reviews on those since I'm not 100% sure they are correct. |
mengelbart
approved these changes
Nov 15, 2024
This PR adds a missing if-else.
00dfb3e to
8fce7e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a deviation from the GCC rfc spec.
Reference issue
Fixes #286